Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: resolve panic issue in script when label is specified during bundle build #2494

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

l-qing
Copy link
Contributor

@l-qing l-qing commented Jan 10, 2025

reproduction steps

cd operatorhub/

wget https://storage.googleapis.com/tekton-releases/operator/previous/v0.74.0/release.yaml

export BUNDLE_ARGS="--workspace kubernetes --operator-release-version 1.2.3 --channels alpha --default-channel alpha --fetch-strategy-release-manifest --release-manifest $(pwd)/release.yaml --upgrade-strategy-semver --addn-labels key1=val1,key2=val2"

make operator-bundle

-------------------------
Results:
-------------------------

:::::::::::::::::::::::::
::::: update csv
:::::::::::::::::::::::::
Traceback (most recent call last):
  File "/Users/liuqing/code/alauda/katanomi/tekton-operator/operatorhub/./tools/bundle.py", line 328, in <module>
    newCSVmods(config)
  File "/Users/liuqing/code/alauda/katanomi/tekton-operator/operatorhub/./tools/bundle.py", line 235, in newCSVmods
    csv['metadata']['labels'].update(config["addn-labels"])
    ~~~~~~~~~~~~~~~^^^^^^^^^^
KeyError: 'labels'
make: *** [operator-bundle] Error 1

Changes

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

See the contribution guide for more details.

Release Notes

NONE

@tekton-robot tekton-robot added the release-note-none Denotes a PR that doesnt merit a release note. label Jan 10, 2025
@tekton-robot tekton-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jan 10, 2025
@tekton-robot
Copy link
Contributor

Hi @l-qing. Thanks for your PR.

I'm waiting for a tektoncd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tekton-robot tekton-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jan 10, 2025
@jkhelil
Copy link
Member

jkhelil commented Jan 10, 2025

/approve

@tekton-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jkhelil

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 10, 2025
@jkhelil
Copy link
Member

jkhelil commented Jan 10, 2025

/ok-to-test

@tekton-robot tekton-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jan 10, 2025
@l-qing
Copy link
Contributor Author

l-qing commented Jan 10, 2025

/retest-required

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note-none Denotes a PR that doesnt merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants