test: use a JavaScript based config file format #1634
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…config. Co-authored-by: mShan0 <[email protected]> Co-authored-by: Michael Sun <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1634 +/- ##
==========================================
+ Coverage 78.48% 79.16% +0.67%
==========================================
Files 93 93
Lines 4861 4861
Branches 933 933
==========================================
+ Hits 3815 3848 +33
+ Misses 750 709 -41
- Partials 296 304 +8 ☔ View full report in Codecov by Sentry. |
…thur/test-js-config
…le across different tests.
arthurschreiber
force-pushed
the
arthur/test-js-config
branch
from
25b6974 to
628a3c2
Compare
package.json
Outdated
| @@ -85,7 +85,7 @@ | |||
| "docs": "typedoc", | |||
| "lint": "eslint src test --ext .js,.ts && tsc", | |||
| "test": "mocha --forbid-only test/unit test/unit/token test/unit/tracking-buffer", | |||
| "test-integration": "mocha --forbid-only test/integration/", | |||
| "test-integration": "mocha test/integration/", | |||
There was a problem hiding this comment.
Hi @arthurschreiber , is this forbid-only removed by an accident or it will inference with the new configuration handle for integration test? Or just for easy debugging?
There was a problem hiding this comment.
Ah, no, that's a mistake and needs to be reverted before this can be merged. Good catch!
|
🎉 This PR is included in version 18.2.4 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This replaces the previously used JSON based configuration file with a JavaScript based configuration file.
The new config format allows to represent configurations that wouldn't have been possible with the JSON format, like the proposed token credential support.