Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ADD/#49] 필터링 재설정 / Text 컴포넌트 구현 #50

Merged
merged 7 commits into from
Jul 11, 2024

Conversation

Hyobeen-Park
Copy link
Member

⛳️ Work Description

  • Main text
  • Sub text

📸 Screenshot

📢 To Reviewers

  • text 컴포넌트 먼저 만들어보았습니다!

@Hyobeen-Park Hyobeen-Park added ADD ➕ 부수적인 코드 추가 및 라이브러리 추가, 새로운 파일 생성 효빈💚 효빈 labels Jul 11, 2024
@Hyobeen-Park Hyobeen-Park self-assigned this Jul 11, 2024
Copy link
Member

@leeeyubin leeeyubin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM~

Comment on lines +15 to +20
Text(
text = text,
style = TerningTheme.typography.title3,
color = Black,
modifier = modifier,
)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

이 modifier는 추후에 쓰일 예정인가용???

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

네!! 나중에 padding 적용할 때 사용될 예정입니다요~

Copy link
Contributor

@arinming arinming left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.!!!!!!!!

Copy link
Member

@boiledEgg-s boiledEgg-s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

퍼펙트!!

…text-component

# Conflicts:
#	feature/src/main/res/values/strings.xml
@Hyobeen-Park Hyobeen-Park merged commit 0795434 into develop Jul 11, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ADD ➕ 부수적인 코드 추가 및 라이브러리 추가, 새로운 파일 생성 효빈💚 효빈
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ADD] 필터링 재설정 / Text 컴포넌트 구현
4 participants