Add basic tests to wasm with modifying JS runtime with forked wasm_exec.js #5
Conversation
There was a problem hiding this comment.
I'm not sure about how testing is implemented currently.
It'll make it harder for people who use the lib to test their code, a Go program that does the setting up in a temporary directory and then executing it might be a better idea as that'll allow people to go install the binary at least.
| ``` | ||
| GOOS=js GOARCH=wasm go get -u github.com/teamortix/golang-wasm/wasm | ||
| ``` | ||
| > To run tests, run [test.sh](./testing/test.sh) |
There was a problem hiding this comment.
| > To run tests, run [test.sh](./testing/test.sh) | |
| > To run tests, run [test.sh](./testing/test.sh). |
| ```bash | ||
| sh testing/test.sh . # Test all files in directory. | ||
|
|
||
| sh testing/wasm_test.go # Test only a single file. |
There was a problem hiding this comment.
I think you are missing the test.sh argument.
| > To run tests, run [test.sh](./testing/test.sh) | ||
|
|
||
| ```bash | ||
| sh testing/test.sh . # Test all files in directory. |
There was a problem hiding this comment.
Consider just making testing/test.sh executable instead of forcing users to invoke it with sh explicitly.
| } | ||
|
|
||
| func TestSetupCorrectly(t *testing.T) { | ||
| if funcWrapper.Type() != js.TypeFunction { |
There was a problem hiding this comment.
Test order is not guaranteed so funcWrapper may not be set at this point in time. It'll be a better idea to just use the Expect API provided in Objects.
No description provided.