-
-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tf1G Support #25
Merged
Merged
tf1G Support #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tdulcet
force-pushed
the
primenet-2.2
branch
from
September 7, 2024 17:00
b702167
to
585e2b2
Compare
tdulcet
reviewed
Sep 8, 2024
primenet.py
Outdated
Comment on lines
4652
to
4734
if assignment.work_type == PRIMENET.WORK_TYPE_FACTOR and assignment.n >= 1000000000: | ||
any_tf1g = True | ||
if assignment_unreserve(adapter, assignment): | ||
tasks = [ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note that this will remove all TF1G assignments from the work file even if the unreserve subsequently fails.
tdulcet
force-pushed
the
tf1g
branch
3 times, most recently
from
September 16, 2024 11:42
6e35d95
to
7de47db
Compare
tdulcet
force-pushed
the
tf1g
branch
3 times, most recently
from
September 23, 2024 16:05
3244609
to
992ff0a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently a work in progress, but a functional prototype as of now. I wanted to get a PR open so I can track the TODO items, and solicit review of the implementation.