Support for generation of Jupyter Notebook #72
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Works for tests/tcp/01-iperf.npf test, but not much more testing
This also renames all features to y_FEATURE So instead of THROUGHPUT the column will be y_THROUGHPUT That allows to find "outputs"/features easily without any metadata given to the dataset
Add decide_graph_type
- You can't use a global constant in the template to toggle Jinja if statements (settings like log scale, or savefig). - The variables used are from the dict of the rendering function.
Run with `python3 npf_run.py --test tests/tcp/04-iperf.npf --notebook results/iperf2/2.0.9/iperf-4-nb.ipynb`
Jupyter notebooks
|
It seems there's a problem with the checks of this branch. Does it work locally ? |
tbarbette
commented
Aug 7, 2024
tbarbette
commented
Aug 7, 2024
|
|
||
|
|
||
| def prepare_notebook_export(datasets: List[tuple], all_results_df: pd.DataFrame, path: str, config): | ||
| # SIMTODO: (help) why could there be multiple datasets? |
There was a problem hiding this comment.
@Simcornelis because there are multiple series
| @@ -0,0 +1,77 @@ | |||
| from npf.types.dataset import convert_to_xyeb | |||
|
@Simcornelis please rebase and fix the errors introduced in the tests :) |
|
New pull request to be done. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.