Replace deprecated pytest.warns(None)
#922
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Alternatively, I can change it to use |
I think it's best to do this |
|
I'm sorry, which one? |
Probably the first one, seems like that makes the most sense. |
Replace the deprecated `pytest.warns(None)` with the standard library `warnings.catch_warnings(record=True)`, in order to fix compatibility with pytest-8.1.2.
mgorny
force-pushed
the
pytest-warns-none
branch
from
3aa8cc9
to
6a0cd02
Compare
|
I've updated the pull request now. |
michaelboulton
approved these changes
May 11, 2024
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace the deprecated
pytest.warns(None)use with theerrorwarning filter, as recommendedin pytest-dev/pytest#9404 (comment). With this change, the tests pass with pytest-8.1.1.