Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Write converters without anonymous classes #113

Merged
merged 3 commits into from
Aug 21, 2024

Conversation

tarao
Copy link
Owner

@tarao tarao commented Aug 21, 2024

Fix #111

Copy link

codecov bot commented Aug 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (master@e7e6621). Learn more about missing BASE report.
Report is 4 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##             master     #113   +/-   ##
=========================================
  Coverage          ?   93.79%           
=========================================
  Files             ?       15           
  Lines             ?      516           
  Branches          ?      103           
=========================================
  Hits              ?      484           
  Misses            ?       32           
  Partials          ?        0           
Flag Coverage Δ
3 93.79% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tarao tarao force-pushed the no-anonymous-converter-class branch from 6e825e6 to 9e79aa5 Compare August 21, 2024 04:33
@tarao tarao marked this pull request as ready for review August 21, 2024 04:41
@tarao tarao merged commit 37f5efc into master Aug 21, 2024
16 checks passed
@tarao tarao deleted the no-anonymous-converter-class branch August 21, 2024 04:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"New anonymous class definition will be duplicated at each inline site" warning
1 participant