Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

start: fix start Tarantool 3 with encrypted etcd #970

Merged
merged 1 commit into from
Oct 8, 2024
Merged

start: fix start Tarantool 3 with encrypted etcd #970

merged 1 commit into from
Oct 8, 2024

Conversation

patapenka-alexey
Copy link
Contributor

This patch fixes an incorrect SSL certificate parameter name.

Closes #938

themilchenko
themilchenko reviewed Oct 4, 2024
View reviewed changes
Copy link
Contributor

@themilchenko themilchenko left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the patch!
Please, add a CHANGELOG entry.

@patapenka-alexey
start: failed to start Tarantool 3 with encrypted etcd
5f05dfc 
This patch fixes an incorrect SSL certificate parameter name.

Closes #938
@patapenka-alexey patapenka-alexey force-pushed the patapenka-alexey/gh-938-failed-to-start-tarantool3-with-encrypted-etcd branch from b86ad9b to 5f05dfc Compare October 4, 2024 11:50
themilchenko
themilchenko reviewed Oct 4, 2024
View reviewed changes
Copy link
Contributor

@themilchenko themilchenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I forgot to tell that it would also be great to write an integration test for this fix to make sure everything works well.

@oleg-jukovec
Copy link
Contributor

oleg-jukovec commented Oct 7, 2024 •
edited
Loading

I forgot to tell that it would also be great to write an integration test for this fix to make sure everything works well.

We don't have such integration tests now: part/full configuration is stored in an external storage. So it could be non-trivial.
Let's write such tests in a separate task.

@patapenka-alexey please, create an issue to create integration tests: tt start/stop + a configuration located in etcd/tcs with/without TLS.

@oleg-jukovec oleg-jukovec requested review from oleg-jukovec and removed request for DerekBum October 7, 2024 13:31
oleg-jukovec
oleg-jukovec approved these changes Oct 7, 2024
View reviewed changes
Copy link
Contributor

@oleg-jukovec oleg-jukovec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, change the commit title:

start: failed to start Tarantool 3 with encrypted etcd ->
start: fix start Tarantool 3 with encrypted etcd

@themilchenko
Copy link
Contributor

themilchenko commented Oct 7, 2024 •
edited by oleg-jukovec
Loading

I forgot to tell that it would also be great to write an integration test for this fix to make sure everything works well.

We don't have such integration tests now: part/full configuration is stored in an external storage. So it could be non-trivial.

Let's write such tests in a separate task.

@patapenka-alexey please, create an issue to create integration tests: tt start/stop + a configuration located in etcd/tcs with/without TLS.

Oh, got it. Sorry for misleading.

@oleg-jukovec oleg-jukovec added the full-ci Enables full ci tests label Oct 7, 2024
@patapenka-alexey patapenka-alexey mentioned this pull request Oct 7, 2024
Open
@patapenka-alexey
Copy link
Contributor Author

patapenka-alexey commented Oct 7, 2024 •
edited
Loading

please, create an issue to create integration tests: tt start/stop + a configuration located in etcd/tcs with/without TLS.

#971

@patapenka-alexey patapenka-alexey changed the title start: failed to start Tarantool 3 with encrypted etcd start: fix start Tarantool 3 with encrypted etcd Oct 7, 2024
@oleg-jukovec oleg-jukovec merged commit 88477a6 into master Oct 8, 2024
42 of 44 checks passed
@oleg-jukovec oleg-jukovec deleted the patapenka-alexey/gh-938-failed-to-start-tarantool3-with-encrypted-etcd branch October 8, 2024 08:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@themilchenko themilchenko themilchenko approved these changes

@oleg-jukovec oleg-jukovec oleg-jukovec approved these changes

Assignees
No one assigned
Labels
full-ci Enables full ci tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

start: failed to start Tarantool 3 with encrypted etcd
3 participants
@patapenka-alexey @oleg-jukovec @themilchenko