Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

api: update the generator with tarantool 3.2.0 #7

Merged
merged 2 commits into from
Oct 10, 2024

Conversation

dmyger
Copy link
Contributor

@dmyger dmyger commented Oct 9, 2024

Fix parsing box/errcode.h constants.

Closes #6

@dmyger dmyger force-pushed the dmyger/gh-6-Update-the-generator branch from 2bfa473 to 7994950 Compare October 9, 2024 17:38
Copy link
Collaborator

@oleg-jukovec oleg-jukovec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the patch! Looks great, but I have few non-critical comments.

error.go Outdated Show resolved Hide resolved
error.go Outdated Show resolved Hide resolved
flag.go Outdated Show resolved Hide resolved
generate.sh Outdated Show resolved Hide resolved
generate.sh Outdated Show resolved Hide resolved
generate.sh Outdated Show resolved Hide resolved
@oleg-jukovec
Copy link
Collaborator

Please, add a changelog entry.

@dmyger dmyger force-pushed the dmyger/gh-6-Update-the-generator branch 2 times, most recently from 9202040 to 79c48c0 Compare October 10, 2024 13:36
@dmyger dmyger force-pushed the dmyger/gh-6-Update-the-generator branch 2 times, most recently from cf849d9 to 7b02587 Compare October 10, 2024 13:49
Copy link
Collaborator

@oleg-jukovec oleg-jukovec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the patch, just a one small fix required.

CHANGELOG.md Outdated Show resolved Hide resolved
@dmyger dmyger force-pushed the dmyger/gh-6-Update-the-generator branch from 7b02587 to 6622a3d Compare October 10, 2024 14:38
@oleg-jukovec oleg-jukovec merged commit 44b6566 into master Oct 10, 2024
7 checks passed
@oleg-jukovec oleg-jukovec deleted the dmyger/gh-6-Update-the-generator branch October 10, 2024 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update the generator
3 participants