Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixing saving title button + caching firebase and config key files. #269

Merged
merged 3 commits into from
Jul 1, 2024

Conversation

Saarxp
Copy link
Contributor

@Saarxp Saarxp commented Jun 30, 2024

i fixed the save title button + fixed it when ever you are editing you cannot exit from the edit mode and you have to refresh the site/ go back on page.
+
i cached the firebaserc , firebase.json , configKey.ts to prevent everyone to override each other.

Copy link
Owner

@talyaron talyaron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool Saar. I have approved. please make PR next time fo each item.

@talyaron talyaron merged commit 55e72eb into talyaron:dev Jul 1, 2024
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants