Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added save text in title&cards #267

Merged
merged 6 commits into from
Jul 1, 2024
Merged

Added save text in title&cards #267

merged 6 commits into from
Jul 1, 2024

Conversation

ShakedEdr1
Copy link
Contributor

No description provided.

talyaron
talyaron requested changes Jun 30, 2024
View reviewed changes
Copy link
Owner

@talyaron talyaron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Shaked,
Please correct two things:

  1. the button hide some of the text in title.
  2. on the svg you added, change stroke to stroke="currentColor"

talyaron
talyaron approved these changes Jul 1, 2024
View reviewed changes
Copy link
Owner

@talyaron talyaron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi shaked, I approved. next time please use SVG and not image. also, I have move the position to right -6px. also, pay attention to PR to dev.
Thanks

@talyaron talyaron merged commit dfc76ee into talyaron:main Jul 1, 2024
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@talyaron talyaron talyaron approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ShakedEdr1 @talyaron