Feature/enable viewfolder dragging #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guycastel
suggested changes
May 10, 2018
| } | ||
|
|
||
| if (curIndex != -1 && curIndex > 0) | ||
| return childrenArr[curIndex - 1].clientHeight; |
There was a problem hiding this comment.
Can be reduced to if (curIndex > 0):
if (curIndex > 0) {
...
}
| } | ||
|
|
||
| if (curIndex != -1 && curIndex < childrenArr.length - 1) | ||
| return childrenArr[curIndex + 1].clientHeight; |
| @@ -97,9 +152,34 @@ class UITree extends Component { | |||
| dragStart = (id, dom, e) => { | |||
| if (this.props.disableDragging) {return;} | |||
| if ((this.props.disableRootDrag) && (id == 1)) {return;} | |||
| if (id == 2 && this.props.tree.module === "ROOT") {return;} | |||
There was a problem hiding this comment.
For above 3 ifs:
if (...) {
return;
}
|
|
||
|
|
||
| // exit from presets tree if its not favorites module | ||
| if (this.props.tree.module !== "ROOT" && this.props.tree.module !== "Favorites") {return;} |
| let nextElement = this.childrenRoot.children[0]; | ||
|
|
||
| while (nextElement.innerText != this.dragging.dom.innerText && | ||
| !nextElement.classList.contains("placeholder")) |
There was a problem hiding this comment.
while ((nextElement.innerText != this.dragging.dom.innerText) &&
(!nextElement.classList.contains("placeholder"))) {
...
}
| if (!this._start) | ||
| { | ||
| this.dragEnded(this.state.tree); | ||
| } |
| dragStarted = () => | ||
| { | ||
| if (this.props.onDragStarted) this.props.onDragStarted(); | ||
| }; |
There was a problem hiding this comment.
xxx = () => {
... 2 space indented code ...
};
| dragEnded = (tree) => | ||
| { | ||
| if (this.props.onDragEnded) this.props.onDragEnded(tree.obj); | ||
| }; |
There was a problem hiding this comment.
xxx = () => {
... 2 space indented code ...
};
| if (placeholder) | ||
| { | ||
| curIndex = childrenArr.indexOf(placeholder); | ||
| } |
| getBaseItemHeight = () => { | ||
| let childrenArr = Array.from(this.childrenRoot.children); | ||
| let heightArray = childrenArr.filter(x => x.clientHeight && x.clientHeight > 0).map(x => x.clientHeight); | ||
| let baseHeight = Math.min.apply(null, heightArray); |
There was a problem hiding this comment.
I think that if this is ES6 you can Math.min(...heightArray)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related to OO-1352