Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(protocol): introduce IResolver to replace AddressManager and AddressResolver #18452

Merged
merged 113 commits into from
Nov 10, 2024

Conversation

dantaik
Copy link
Contributor

@dantaik dantaik commented Nov 6, 2024

  • use console2.sol to replace console.sol
  • replace for prank(x,x) with prank(x)
  • rename test stubs, mocks, targets properly
  • recover AddressManager tests
  • split rollup deployment scripts into multipole smaller pieces for reuse.
  • checks if any files are mistakely deleted/changed

@dantaik dantaik changed the title refactor(protocol): introduce IResolver to repleace (AddressManager and AddressResolver) refactor(protocol): introduce IResolver to replace AddressManager and AddressResolver Nov 6, 2024
@dantaik dantaik marked this pull request as ready for review November 6, 2024 05:55
@dantaik dantaik marked this pull request as draft November 6, 2024 05:59
Copy link

openzeppelin-code bot commented Nov 6, 2024

refactor(protocol): introduce IResolver to replace AddressManager and AddressResolver

Generated at commit: fdf4299877bbba812eb8cff296002caf53baa982

🚨 Report Summary

Severity Level Results
Contracts Critical
High
Medium
Low
Note
Total
3
3
0
8
41
55
Dependencies Critical
High
Medium
Low
Note
Total
0
0
0
0
0
0

For more details view the full report in OpenZeppelin Code Inspector

@dantaik dantaik changed the base branch from main to address_resolver2 November 10, 2024 14:37
@dantaik dantaik marked this pull request as ready for review November 10, 2024 14:37
@dantaik dantaik merged commit e66a12c into address_resolver2 Nov 10, 2024
2 of 5 checks passed
@dantaik dantaik deleted the address_resolver branch November 10, 2024 14:57
@dantaik dantaik restored the address_resolver branch November 10, 2024 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant