-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(protocol): introduce IResolver to replace AddressManager and AddressResolver #18452
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
dantaik
commented
Nov 6, 2024
•
edited
Loading
edited
- use console2.sol to replace console.sol
- replace for prank(x,x) with prank(x)
- rename test stubs, mocks, targets properly
- recover AddressManager tests
- split rollup deployment scripts into multipole smaller pieces for reuse.
- checks if any files are mistakely deleted/changed
dantaik
changed the title
refactor(protocol): introduce IResolver to repleace (AddressManager and AddressResolver)
refactor(protocol): introduce IResolver to replace AddressManager and AddressResolver
Nov 6, 2024
refactor(protocol): introduce IResolver to replace AddressManager and AddressResolver
🚨 Report Summary
For more details view the full report in OpenZeppelin Code Inspector |
…mono into address_resolver
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.