Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(repo): remove snaefull-ui #18226

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

dionysuzx
Copy link
Collaborator

@dionysuzx dionysuzx commented Oct 10, 2024

Description of change

I do not believe we need this package anymore. The release-please job also takes way too long, I'm not sure why. There has been no activity on this subpackage for months. If it is needed, then I think we can revert this commit later or re-implement it nicely.

It seems like this package is still used in prod but perhaps we will sunset it soon. Feel free to close this PR at any time if it's causing noise. Thanks!

@dionysuzx dionysuzx changed the title feat: remove snaefull-ui feat(repo): remove snaefull-ui Oct 10, 2024
@dionysuzx dionysuzx changed the title feat(repo): remove snaefull-ui chore(repo): remove snaefull-ui Oct 10, 2024
@dantaik dantaik requested a review from bearni95 October 10, 2024 03:54
@bearni95
Copy link
Contributor

Description of change

I do not believe we need this package anymore. The release-please job also takes way too long, I'm not sure why. There has been no activity on this subpackage for months. If it is needed, then I think we can revert this commit later or re-implement it nicely.

What happens with the vercel deployment and the live site, if the package gets removed?

@KorbinianK
Copy link
Contributor

@d1onys1us The site is still live, but I suppose we can remove it from release-please.
I'd keep the workflows and code, in case we want to update/fix something and create a new release. But removing it from release-please-config.json should do the trick, right?

@dionysuzx
Copy link
Collaborator Author

@d1onys1us The site is still live, but I suppose we can remove it from release-please.

I'd keep the workflows and code, in case we want to update/fix something and create a new release. But removing it from release-please-config.json should do the trick, right?

Yea that would help. But do we plan to keep the site up indefinitely? If not, it could be better to have a sunset plan and totally remove it. Maybe can notify the community and say it's coming down in X days/weeks?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants