fix unreached code

taichi-ishitani · Mar 26, 2024 · 8220db1 · 8220db1
1 parent 82d5531
commit 8220db1
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 9 deletions.
diff --git a/lib/rupkl/node/pkl_object.rb b/lib/rupkl/node/pkl_object.rb
@@ -10,11 +10,7 @@ def evaluate_property(value, objects, scopes)
       end
 
       def property_to_ruby(value, objects, scopes)
-        if value
-          value.to_ruby(scopes)
-        else
-          evaluate_objects(objects, scopes).to_ruby(nil)
-        end
+        evaluate_property(value, objects, scopes).to_ruby(nil)
       end
 
       def evaluate_objects(objects, scopes)

diff --git a/spec/rupkl/node/pkl_object_spec.rb b/spec/rupkl/node/pkl_object_spec.rb
@@ -427,15 +427,15 @@
             #{pkl}
             c = a == b
           PKL
-          node.evaluate(nil) do |n|
+          node.evaluate(nil).then do |n|
             expect(n.properties[-1].value).to be_boolean(true)
           end
 
           node = parser.parse(<<~PKL, root: :pkl_module)
             #{pkl}
             c = a != b
           PKL
-          node.evaluate(nil) do |n|
+          node.evaluate(nil).then do |n|
             expect(n.properties[-1].value).to be_boolean(false)
           end
         end
@@ -445,15 +445,15 @@
             #{pkl}
             c = a == b
           PKL
-          node.evaluate(nil) do |n|
+          node.evaluate(nil).then do |n|
             expect(n.properties[-1].value).to be_boolean(false)
           end
 
           node = parser.parse(<<~PKL, root: :pkl_module)
             #{pkl}
             c = a != b
           PKL
-          node.evaluate(nil) do |n|
+          node.evaluate(nil).then do |n|
             expect(n.properties[-1].value).to be_boolean(true)
           end
         end