Adding support for custom view urls to export & get tabcmd commands #313
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jacalata
requested changes
Nov 13, 2024
| @@ -15,7 +15,7 @@ jobs: | |||
| fail-fast: true | |||
| matrix: | |||
| os: [ubuntu-latest, macos-latest, windows-latest] | |||
| python-version: ['3.8', '3.9', '3.10', '3'] | |||
| python-version: ['3.9', '3.10', '3'] | |||
There was a problem hiding this comment.
ideally 3.12 as well, as it's the current major version
| @@ -221,7 +240,7 @@ def generate_twb(logger, server, args, file_extension, url): | |||
| file_name_with_path = GetUrl.get_name_without_possible_extension(file_name_with_path) | |||
| file_name_with_ext = "{}.{}".format(file_name_with_path, file_extension) | |||
| logger.debug("Saving as {}".format(file_name_with_ext)) | |||
| server.workbooks.download(target_workbook.id, filepath=file_name_with_path, no_extract=False) | |||
| server.workbooks.download(target_workbook.id, filepath=file_name_with_path, include_extract=False) | |||
There was a problem hiding this comment.
this looks like the meaning has been flipped, from 'no_extract' to 'include_extract'. Should it still default to False?
| @@ -138,6 +141,24 @@ def get_view_url(url, logger): # "views/wb-name/view-name" -> wb-name/sheets/vi | |||
| view_name = GetUrl.get_name_without_possible_extension(view_name) | |||
| return DatasourcesAndWorkbooks.get_view_url_from_names(workbook_name, view_name) | |||
|
|
|||
| @staticmethod | |||
| def get_url_parts_from_custom_view_url(url, logger): | |||
| name_parts = url.split("/") # ['views', 'wb-name', 'view-name', 'custom-view-id', 'custom-view-name'] | |||
There was a problem hiding this comment.
Could we do this custom view id logic once for Get_command and Export_command? Or perhaps at least move all the url parsing methods into datasources_and_workbooks so that we can keep an eye on the repeated code?
| @@ -165,6 +165,7 @@ export.errors.need_country_and_languge=The options --country and --language must | |||
| export.errors.white_space_workbook_view=The name of the workbook or view to export cannot include spaces. Use the normalized name of the workbook or view as it appears in the URL. | |||
| export.errors.requires_workbook_view_name=The ''{0}'' command requires a <workbook>/<view> name | |||
| export.errors.requires_workbook_view_param=The ''{0}'' command requires a <workbook>/<view> parameter, and there must be at least one slash (/) in this parameter | |||
| export.errors.requires_valid_custom_view_uuid=The URL for custom views must contain a valid custom view luid | |||
There was a problem hiding this comment.
You should add this English string to all the locales, so that there is at least a message while we wait for translation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding support for export of custom views to pdf, png & csv formats in
export&gettabcmd commands