Allow to set NLTK options via TabPy config #471
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add convenience function for building the config dict
Allow to modify the NLTK download path and proxy settings via the tabpy config file.
|
Looks good. Could you update one of the integration tests for models with the new settings (https://github.com/tableau/TabPy/tree/master/tests/integration)? |
|
Sure, I'm having a busy week but I hope to do this before the weekend. |
|
@ElPincheTopo would appreciate if you could address integration test comment so that we can merge your change! thanks! |
|
Hello, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create a convenience function to expose the settings file to scripts, added NLTK options to the example script and updated SentimentAnalysis.py to use the download path and proxy settings defined in the nltk parameters in the config.