Skip to content

Commit

Permalink
test: add reproducer for SIGBUS issue caused by journal truncation
Browse files Browse the repository at this point in the history
The added code fails without the previous commit.

For issue #24320.

(cherry picked from commit 3b0ae13)
  • Loading branch information
yuwata authored and orgads committed Aug 12, 2024
1 parent db14a20 commit 32f9e12
Showing 1 changed file with 35 additions and 0 deletions.
35 changes: 35 additions & 0 deletions src/journal/test-journal-flush.c
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@
#include "alloc-util.h"
#include "chattr-util.h"
#include "journal-internal.h"
#include "logs-show.h"
#include "macro.h"
#include "managed-journal-file.h"
#include "path-util.h"
Expand Down Expand Up @@ -67,6 +68,40 @@ static void test_journal_flush_one(int argc, char *argv[]) {
if (++n >= limit)
break;
}

if (n == 0)
return (void) log_tests_skipped("No journal entry found");

/* Open the new journal before archiving and offlining the file. */
sd_journal_close(j);
assert_se(sd_journal_open_directory(&j, dn, 0) >= 0);

/* Read the online journal. */
assert_se(sd_journal_seek_tail(j) >= 0);
assert_se(sd_journal_previous(j) > 0);
printf("current_journal: %s (%i)\n", j->current_file->path, j->current_file->fd);
assert_se(show_journal_entry(stdout, j, OUTPUT_EXPORT, 0, 0, NULL, NULL, NULL, &(dual_timestamp) {}, &(sd_id128_t) {}) >= 0);

uint64_t p;
assert_se(journal_file_tail_end_by_mmap(j->current_file, &p) >= 0);
for (uint64_t q = ALIGN64(p + 1); q < (uint64_t) j->current_file->last_stat.st_size; q = ALIGN64(q + 1)) {
Object *o;

r = journal_file_move_to_object(j->current_file, OBJECT_UNUSED, q, &o);
assert_se(IN_SET(r, -EBADMSG, -EADDRNOTAVAIL));
}

/* Archive and offline file. */
assert_se(journal_file_archive(new_journal->file, NULL) >= 0);
assert_se(managed_journal_file_set_offline(new_journal, /* wait = */ true) >= 0);

/* Read the archived and offline journal. */
for (uint64_t q = ALIGN64(p + 1); q < (uint64_t) j->current_file->last_stat.st_size; q = ALIGN64(q + 1)) {
Object *o;

r = journal_file_move_to_object(j->current_file, OBJECT_UNUSED, q, &o);
assert_se(IN_SET(r, -EBADMSG, -EADDRNOTAVAIL, -EIDRM));
}
}

TEST(journal_flush) {
Expand Down

0 comments on commit 32f9e12

Please sign in to comment.