Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI: Fix error when running on host-arm64 #503

Merged
merged 1 commit into from
Oct 21, 2024
Merged

CI: Fix error when running on host-arm64 #503

merged 1 commit into from
Oct 21, 2024

Conversation

ChinYikMing
Copy link
Collaborator

Close #502

@jserv jserv added this to the release-2024.2 milestone Oct 20, 2024
jserv
jserv requested changes Oct 20, 2024
View reviewed changes
Copy link
Contributor

@jserv jserv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Improve the git commit message to address the rationale of the proposed changes. What confuses me is the entry in arm64 host.

@ChinYikMing
CI: Fix error when running on host-arm64
07e4cf2 
When pulling a base image from Docker Hub, the architecture
defaults to that of the native host, which is typically x86_64
or amd64 on GitHub runners. Since the run-on-arch-action
GitHub Action aims to run rv32emu on an ARM64 Ubuntu image, it
attempts to pull the native host manifest (either x86_64 or
amd64), resulting in a 'no match for platform in manifest'
error unless the --platform option is specified. Therefore,
specifying the --platform option as linux/arm64 resolves this
issue.

Close sysprog21#502
@ChinYikMing
Copy link
Collaborator Author

ChinYikMing commented Oct 20, 2024 •
edited
Loading

When trying to run arm64v8/ubuntu:22.04 on a x86 machine, the following similar result will be shown:

$ docker run -it arm64v8/ubuntu:22.04
Unable to find image 'arm64v8/ubuntu:22.04' locally
22.04: Pulling from arm64v8/ubuntu
docker: no matching manifest for linux/amd64 in the manifest list entries.

@jserv
Copy link
Contributor

jserv commented Oct 20, 2024

When trying to run arm64v8/ubuntu:22.04 on a x86 machine, the following similar result will be shown:

So, will the proposed change work with Docker?

@ChinYikMing
Copy link
Collaborator Author

When trying to run arm64v8/ubuntu:22.04 on a x86 machine, the following similar result will be shown:

So, will the proposed change work with Docker?

Yes, the proposed change ensures that the Docker engine uses the appropriate manifest when pulling the base image.

@jserv jserv merged commit 164da62 into sysprog21:master Oct 21, 2024
8 checks passed
@jserv
Copy link
Contributor

jserv commented Oct 21, 2024

Thank @ChinYikMing for contributing!

@ChinYikMing ChinYikMing deleted the fix/host-arm64-ci branch October 21, 2024 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jserv jserv jserv requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
release-2024.2
Development

Successfully merging this pull request may close these issues.

No match for platform in manifest: not found on host-arm64
2 participants
@ChinYikMing @jserv