feat(shield): enable kubernetes-metadata by default and decrease delegated nodes number to 0 #2038
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…gated nodes number to 0
aroberts87
reviewed
Nov 15, 2024
| @@ -100,7 +100,9 @@ true | |||
| {{- $config := dict | |||
| "k8s_cluster_name" .Values.cluster_config.name | |||
| "collector" (include "common.collector_endpoint" .) | |||
| "collector_port" .Values.sysdig_endpoint.collector.port }} | |||
| "collector_port" .Values.sysdig_endpoint.collector.port | |||
| "k8s_delegated_nodes" (dig "k8s_delegated_nodes" 0 .Values.host.additional_settings) | |||
There was a problem hiding this comment.
I imagine we'd want to have a check to see if features.kubernetes_metadata.enabled has been set to false here. If this feature is turned off I think we'd like the agent/host shield to run with the default values (unless manually overridden of course).
There was a problem hiding this comment.
@mavimo @irozzo-1A WDYT?
There was a problem hiding this comment.
Yep, I agree that would be better to use the default if kubernetes_metadata is disabled
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Enable kubernetes-metadata by default and decrease delegated nodes number to 0
Checklist
feat(agent,node-analyzer,sysdig-deploy):)