Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(admission-controller docs): Edit chart for clarity, consistency and correctness #1206

Merged
merged 23 commits into from
Aug 4, 2023

Conversation

radhikapc
Copy link
Collaborator

@radhikapc radhikapc commented Jun 29, 2023

What this PR does / why we need it:

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

  • Title of the PR starts with type and scope, (e.g. feat(agent,node-analyzer,sysdig-deploy):)
  • Chart Version bumped for the respective charts
  • Variables are documented in the README.md (or README.tpl in some charts)
  • Check GithubAction checks (like lint) to avoid merge-check stoppers
  • All test files are added to the tests folder of their respective chart and have a "_test" suffix

Check Contribution guidelines in README.md for more insight.

@radhikapc radhikapc requested a review from a team as a code owner June 29, 2023 23:17
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR title does not comply with regex: ^(\w*)(?:\(([\w\$\.\,\-\*\s]*)\))?\:\s?(.*)$!
Check PR guidelines at https://github.com/sysdiglabs/charts/blob/master/README.md#pull-requests

@aroberts87 aroberts87 changed the title feat (doc: Admission Controller): Edit chart for clarity, consistency and correctness <DRAFT> doc(admission-controller): Edit chart for clarity, consistency and correctness <DRAFT> Jun 30, 2023
@github-actions github-actions bot dismissed their stale review June 30, 2023 15:49

All good!

@mavimo mavimo marked this pull request as draft July 11, 2023 15:24
@radhikapc radhikapc changed the title doc(admission-controller): Edit chart for clarity, consistency and correctness <DRAFT> doc(admission-controller): Edit chart for clarity, consistency and correctness Jul 31, 2023
@radhikapc radhikapc requested review from admangum, aroberts87, claffin and airadier and removed request for admangum July 31, 2023 20:11
@radhikapc radhikapc changed the title doc(admission-controller): Edit chart for clarity, consistency and correctness feat(admission-controller docs): Edit chart for clarity, consistency and correctness Jul 31, 2023
@radhikapc radhikapc marked this pull request as ready for review July 31, 2023 21:30
charts/admission-controller/README.tpl Show resolved Hide resolved
charts/admission-controller/README.tpl Outdated Show resolved Hide resolved
@airadier airadier merged commit 85b74e1 into master Aug 4, 2023
5 checks passed
@airadier airadier deleted the admission-controller branch August 4, 2023 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants