Update deploy workflow #331
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the deploy workflow to prevent the error as seen in https://github.com/synthetichealth/module-builder/actions/runs/8379771158/job/22947474881
To be frank, I don't fully understand the error but it doesn't happen locally, so I upgraded the version of node used by the workflow from 12 (many years old now) to 20, and added the same two tweaks necessary to get it to run locally, ie, the
--legacy-peer-depsflag as mentioned in #318 and an SSL env var to prevent an error in build.This continues to be a bandage over very old versions of dependencies, but at least it's a quick update.