Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add static Synthea records and tests #2

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

hadleynet
Copy link

@hadleynet hadleynet commented Jun 14, 2022

JIRA Ticket:
N/A

User Story or Bug Summary:
Adds a set of Synthea generated test files to the BFD pipeline loader tests


What Does This PR Do?

Add Synthea generated test files.

Adds a set of test files that were generated by Synthea to the bfd-pipeline-ccw-rif module's unit tests. The aim to provide an indication if the beneficiary-fhir-data code is changed in ways that would break import of Synthea-generated data. The number of beneficiaries was minimized to a set that covers all claim types/

The Synthea data was generated as follows (running from Synthea home dir):

  1. ./run_synthea -s 1010 -cs 0 -r 20210520 -e 20210520 -p 20 --exporter.fhir.export=false --exporter.bfd.export=true --exporter.years_of_history=10 --generate.only_alive_patients=true -a 70-80
  2. ./gradlew rifMinimize
  3. cp output/bfd_min/* $BFD_HOME/apps/bfd-model/bfd-model-rif-samples/src/main/resources/rif-synthea

Local testing indicates that adding these Synthea generated test files adds 3 seconds on average to the build and test time.

If you're reviewing this PR, please check for these things in particular:

  • Verify all PR security questions and checklists have been completed and addressed.

What Security Implications Does This PR Have?

Submitters should complete the following questionnaire:

  • If the answer to any of the questions below is Yes, then you must supply a link to the associated Security Impact Assessment (SIA), security checklist, or other similar document in Confluence here: N/A

    • Does this PR add any new software dependencies?
      • Yes
      • [x ] No
    • Does this PR modify or invalidate any of our security controls?
      • Yes
      • [ x] No
    • Does this PR store or transmit data that was not stored or transmitted before?
      • Yes
      • [ x] No
  • If the answer to any of the questions below is Yes, then please add @StewGoin as a reviewer, and note that this PR should not be merged unless/until he also approves it.

    • Do you think this PR requires additional review of its security implications for other reasons?
      • Yes
      • [ x] No

What Needs to Be Merged and Deployed Before this PR?

This PR cannot be either merged or deployed until the following prerequisite changes have been fully deployed:

  • N/A

Submitter Checklist

I have gone through and verified that...:

  • [ x] I have named this PR and branch so they are automatically linked to the (most) relevant Jira issue. Ie: BFD-123: Adds foo (I don't believe that there is a corresponding issue for this PR).
  • [x ] This PR is reasonably limited in scope, to help ensure that:
    1. It doesn't unnecessarily tie a bunch of disparate features, fixes, refactorings, etc. together.
    2. There isn't too much of a burden on reviewers.
    3. Any problems it causes have a small "blast radius".
    4. It'll be easier to rollback if that becomes necessary.
  • [x ] This PR includes any required documentation changes, including README updates and changelog / release notes entries.
  • [x ] All new and modified code is appropriately commented, such that the what and why of its design would be reasonably clear to engineers, preferably ones unfamiliar with the project.
  • [x ] All tech debt and/or shortcomings introduced by this PR are detailed in TODO and/or FIXME comments, which include a JIRA ticket ID for any items that require urgent attention.
  • [x ] Reviews are requested from both:
    • At least two other engineers on this project, at least one of whom is a senior engineer or owns the relevant component(s) here.
    • Any relevant engineers on other projects (e.g. DC GEO, BB2, etc.).
  • [x ] Any deviations from the other policies in the DASG Engineering Standards are specifically called out in this PR, above.
    • Please review the standards every few months to ensure you're familiar with them.

@hadleynet hadleynet changed the title WIP: Add static Synthea records and tests Add static Synthea records and tests Jul 5, 2022
@hadleynet hadleynet marked this pull request as ready for review July 5, 2022 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant