Redo feed builder fix

[vbjay]

• upgrade framework version for feedbuilder
• make feedbuilder responsive
• load icons from os
• get human readable file sizes
• select listview items by typing regex pattern
• functionality and ui improvements
  Feed builder rework because of of merge conflicts.

[vbjay]

Ready to merge

[robinwassen]

Hi @vbjay!

I appreciate the changes you have done, but it seems like you managed to revert some of the later fixes to the project.

For example:

• Removing FileLockWait(); in FileUpdateTask.cs and adding the commented wait logic
• Removing FileSystem.CopyAccessControl(...) in FileUpdateTask.cs

I will go through the changes and see how we can perform the merge gracefully.

[vbjay]

I'll look. I tried really hard not to do that. I'll go through the diff again.

…

On Wed, May 31, 2017, 3:18 AM Robin Andersson ***@***.***> wrote: Hi @vbjay <https://github.com/vbjay>! I appreciate the changes you have done, but it seems like you managed to revert some of the later fixes to the project. *For example:* - Removing FileLockWait(); in FileUpdateTask.cs and adding the commented wait logic - Removing FileSystem.CopyAccessControl(...) in FileUpdateTask.cs I will go through the changes and see how we can perform the merge gracefully. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#99 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ADdhsX4D_m6nM5ayqDBq_vG9eKubrgE3ks5r_RRIgaJpZM4NoGaq> .

[vbjay]

Let me know if there is anything else.

[vbjay]

I understand other things taking your time. I had to redo this work because it was ignored the first time. Am i wasting my time with trying to give back to this project?

[robinwassen]

Hi @vbjay,

It is my ambition to merge this - but it will take some time since I am usually very thorough when reviewing changes and want to understand each line that is changed to determine the impact of the change.

Which makes it take some time when the change is on 2500 LOC.

Regards,
Robin

[robinwassen]

I have reviewed each commit up to d2a4fc9 this far.

[robinwassen]

Marking the method as async does not make it run async per default.

All places that calls InitializeFormSettings() also need to be changed.

Example:

public class AsyncTestClass
{
	// Output:
	// Initialize() done
	// Run() done
	public void Run()
	{
		Initialize();
		Console.WriteLine("Run() done");
	}

	// Output:
	// Run() done
	// Initialize() done
	public void RunAsync()
	{
		Task.Run(Initialize);
		Console.WriteLine("Run() done");
	}


	private async Task Initialize()
	{
		Thread.Sleep(2000);
		Console.WriteLine("Initialize() done");
	}
}

[robinwassen]

I see that InitializeFormSettings() is called with the await keyword in a later commit, don't understand why it is made async if it is only called sync

[vbjay]

I'll look again. I knew it was sync in the load of the program. But notice it's different when you load a file. I knew that in load we want it to be sync.

[robinwassen]

@vbjay Do not worry about the conflict.

Some questions I have:

• What is the reason that you upgraded to .NET 4.6.2?
• What is the purpose of including the RX .NET package?

[vbjay]

Look at the next commit for why I added Rx.

I upgraded to 4.62 because I wanted framework 4.0 stuff. It also runs on windows 7sp1 and higher. Windows XP support should not be a factor. Microsoft dumped their support for xp in 2014. We should too. O

[robinwassen]

@vbjay Sorry, my mistake about the upgrade. Thought it was from 4.5 -> 4.6.2 which left me puzzling, but 3.5 -> 4.x makes more sense!

Thanks! Everything is a bit more clear now, so I can keep on working with the review and merge.

[robinwassen]

Most of the refactors and smaller changes has been merged now.

I noticed some more collateral damage in the commits, so I am going through commit per commit and cherry-pick them to the branch feedbuilder-improvements and review all changes in detail.

One comparision is the original commit: af11eac?w=1

My modified: 641e4f2?w=1

This can take a while, but I will get through it :)

[vbjay]

@robinwassen I appreciate the work you are doing. It means a lot.