Skip to content
This repository has been archived by the owner on Dec 3, 2024. It is now read-only.

Fix incorrect initialization of Info notification channel #2040

Merged
merged 1 commit into from
Jan 27, 2024

Conversation

the-eclectic-dyslexic
Copy link
Contributor

I was using syncthing as a reference for handling notifications in my app, when I noticed that the "Info" channel appears to be incorrectly initialized.

It looks like it was intended for the Info channel not to vibrate, not to make sound, but only to show a badge. This might be redundant as it's possible every notification pushed to this channel already follows those standards, I am unsure. However, the code used to initialize the Info channel was actually modifying the already created Persistent channel, and thus did nothing.

This pull request fixes, what I think are typos which originated from a copy and paste of the code used to create the Persistent channel.

I think these lines should either be changed as per this pull request, or removed entirely.

Copy link
Member

@imsodin imsodin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That indeed looks like a copy-paste mistake - thanks!

@imsodin imsodin merged commit a22c1b9 into syncthing:main Jan 27, 2024
1 check passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants