Skip to content
This repository has been archived by the owner on Dec 3, 2024. It is now read-only.

Commit

Permalink
Upgrade compile sdk and tools (#2049)
Browse files Browse the repository at this point in the history
Upgrade compile sdk and tools from 33 to 34

This is needed to update Android Gradle Plugin (AGP) and other
dependencies.
  • Loading branch information
adamszewe authored Feb 10, 2024
1 parent b1194b9 commit 6df11ac
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
4 changes: 2 additions & 2 deletions app/build.gradle.kts
Original file line number Diff line number Diff line change
Expand Up @@ -31,8 +31,8 @@ dependencies {
android {
val ndkVersionShared = rootProject.extra.get("ndkVersionShared")
// Changes to these values need to be reflected in `../docker/Dockerfile`
compileSdk = 33
buildToolsVersion = "33.0.2"
compileSdk = 34
buildToolsVersion = "34.0.0"
ndkVersion = "${ndkVersionShared}"

buildFeatures {
Expand Down
2 changes: 1 addition & 1 deletion docker/Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ RUN yes | $SDKMANAGER --licenses > /dev/null
ENV NDK_VERSION 25.2.9519653

# Install other android packages, including NDK
RUN $SDKMANAGER tools platform-tools "build-tools;33.0.2" "platforms;android-33" "extras;android;m2repository" "ndk;${NDK_VERSION}"
RUN $SDKMANAGER tools platform-tools "build-tools;34.0.0" "platforms;android-34" "extras;android;m2repository" "ndk;${NDK_VERSION}"

# Accept licenses of newly installed packages
RUN yes | $SDKMANAGER --licenses
Expand Down

0 comments on commit 6df11ac

Please sign in to comment.