Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancements and Bug Fixes: Long Press, AutoReverse, Toolbar Item, and Accessibility Improvements #58

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

surya3655
Copy link

Description

Improve Long Press Behavior: Updated the logic for long press code using CancellationTokenSource to restrict unintended increments.

Resolve AutoReverse Color Issue: Fixed the issue where the up or down button color appeared disabled when the minimum or maximum value was reached, and AutoReverse was set to true.

Toolbar Item Issue: Resolved the issue where the toolbar item was not visible on the latest devices and did not change its size while rotating.

Improve Inaccessibility: Enhanced the accessibility for NumericUpDown when the button is disabled.

Root Cause of the Issue

Long Press: The increment behavior was not properly managed due to missing cancellation logic.

AutoReverse Color: The disabled color was not correctly restricted when AutoReverse was enabled.

Toolbar Item: Device-specific visibility and resizing issues were not handled.

Inaccessibility: Accessibility for disabled buttons was overlooked.

Description of Change

  1. Implemented CancellationTokenSource to improve long press behavior.
  2. Properly restricted the button colors for AutoReverse mode.
  3. Ensured toolbar items are visible and resize correctly on device rotation.
  4. Improved accessibility for NumericUpDown control when updown button in a disabled state.

Screenshots

AutoReverse:

Before:

image

After:

image

ToolBarItem Not Visible:

Before:

image

After:

image

ToolBarItem Not Visible:

Before:

ToolbarItem.mp4

After:

Toolbaritem1.mp4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant