Add support for time types without seconds #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, if you try to use this guesser with a Time field without seconds, this fails because it doesn't take the withSeconds parameter into consideration. Now, this will add `input_format` = 'H:i' if `withoutSeconds` = true.
|
Thanks for your Pull Request! We love contributions. However, you should instead open your PR on the main repository: This repository is what we call a "subtree split": a read-only subset of that main repository. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, if you try to use this guesser with a Time field without seconds, this fails because it doesn't take the withSeconds parameter into consideration.
Now, this will add
input_format= 'H:i' ifwithoutSeconds= true.I cannot see where the tests are for this, so have not written one, but please advise if there is somewhere I can add one.