Skip to content

Commit

Permalink
Merge branch '5.4' into 6.3
Browse files Browse the repository at this point in the history
* 5.4:
  skip tests that do not work with ICU 71.1
  • Loading branch information
xabbuh committed Nov 30, 2023
2 parents b7a8098 + 9c13bf5 commit 5afc733
Showing 1 changed file with 21 additions and 0 deletions.
21 changes: 21 additions & 0 deletions Tests/Extension/Core/Type/DateTypeTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@
use Symfony\Component\Form\ChoiceList\View\ChoiceView;
use Symfony\Component\Form\FormError;
use Symfony\Component\Form\FormInterface;
use Symfony\Component\Intl\Intl;
use Symfony\Component\Intl\Util\IntlTestHelper;
use Symfony\Component\OptionsResolver\Exception\InvalidOptionsException;

Expand Down Expand Up @@ -91,6 +92,10 @@ public function testSubmitFromSingleTextDateTime()
// we test against "de_DE", so we need the full implementation
IntlTestHelper::requireFullIntl($this, false);

if ('71.1' === Intl::getIcuVersion()) {
$this->markTestSkipped('Skipping test due to a bug in ICU 71.1.');
}

\Locale::setDefault('de_DE');

$form = $this->factory->create(static::TESTED_TYPE, null, [
Expand All @@ -113,6 +118,10 @@ public function testSubmitFromSingleTextDateTimeImmutable()
// we test against "de_DE", so we need the full implementation
IntlTestHelper::requireFullIntl($this, false);

if ('71.1' === Intl::getIcuVersion()) {
$this->markTestSkipped('Skipping test due to a bug in ICU 71.1.');
}

\Locale::setDefault('de_DE');

$form = $this->factory->create(static::TESTED_TYPE, null, [
Expand All @@ -136,6 +145,10 @@ public function testSubmitFromSingleTextString()
// we test against "de_DE", so we need the full implementation
IntlTestHelper::requireFullIntl($this, false);

if ('71.1' === Intl::getIcuVersion()) {
$this->markTestSkipped('Skipping test due to a bug in ICU 71.1.');
}

\Locale::setDefault('de_DE');

$form = $this->factory->create(static::TESTED_TYPE, null, [
Expand All @@ -158,6 +171,10 @@ public function testSubmitFromSingleTextTimestamp()
// we test against "de_DE", so we need the full implementation
IntlTestHelper::requireFullIntl($this, false);

if ('71.1' === Intl::getIcuVersion()) {
$this->markTestSkipped('Skipping test due to a bug in ICU 71.1.');
}

\Locale::setDefault('de_DE');

$form = $this->factory->create(static::TESTED_TYPE, null, [
Expand All @@ -182,6 +199,10 @@ public function testSubmitFromSingleTextRaw()
// we test against "de_DE", so we need the full implementation
IntlTestHelper::requireFullIntl($this, false);

if ('71.1' === Intl::getIcuVersion()) {
$this->markTestSkipped('Skipping test due to a bug in ICU 71.1.');
}

\Locale::setDefault('de_DE');

$form = $this->factory->create(static::TESTED_TYPE, null, [
Expand Down

0 comments on commit 5afc733

Please sign in to comment.