Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to disable printing errors to standard output #100

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

Nyholm
Copy link
Member

@Nyholm Nyholm commented Apr 23, 2021

This is technically a BC break, but since it is an internal tool ¯\(ツ)

Symfony-docs shows the errors:

https://github.com/symfony/symfony-docs/blob/5.x/.github/workflows/ci.yaml#L76-L78

@wouterj
Copy link
Contributor

wouterj commented Apr 24, 2021

Hm.. But we build the -vvv argument. So I dont think it should be related to verbosity.

I'm almost 100% sure that I added -vvv as a desperate move to try to get error output (I added the CI pipeline with 0 config of this tool). I wouldn't give any weight to the docs CI pipeline in any decision about this tool.

That is true, but is that important?

Not really, but it's a good reference (it's the most commonly used documentation build tool, so if it does something, someone probably thought about it and wanted that feature). I think it makes sense to always show errors.

@Nyholm Nyholm changed the title Opt-in to printing errors to standard output Add option to disable printing errors to standard output Apr 25, 2021
@Nyholm
Copy link
Member Author

Nyholm commented Apr 25, 2021

I've updated the PR. It will now just add an option to disable parsing errors on std-out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants