-
Notifications
You must be signed in to change notification settings - Fork 450
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement more keybinds for inputs #2143
Draft
dxrcy
wants to merge
16
commits into
sxyazi:main
Choose a base branch
from
dxrcy:main
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
052f7fd
feat: single-character replace keybind for inputs
dxrcy 5a9c37a
fix: change `replace` keybind description
dxrcy 389dba2
feat: better api to move input cursor to bol/eol
dxrcy f16dbaf
fix: format default keybinds config
dxrcy c4f9c36
fix: make `V` select entire line including leading whitespace
dxrcy f18da6d
refactor: rename `move_::Step` to `move_::OptStep`
dxrcy e17600d
feat: use default value for invalid `move` argument
dxrcy f1dd61a
refactor: rename single-letter variables
dxrcy 5153159
feat: add `--big` parameter to `forward` and `backward` commands
dxrcy 00e78e3
Format
sxyazi b1d8c0c
`<C-a>` and `<Home>` should keep the original behavior
sxyazi 4adee1b
Refactor the `move` command
sxyazi 48a62fb
Use `first()` instead of `get(0)`
sxyazi 7bcc4b6
Merge the match arms
sxyazi b1f5d60
Move `type_str` and `replace_str` to `type` and `replace` commands
sxyazi e253c0c
fix: bracketed paste (Ctrl-v from the terminal) also needs to exit re…
sxyazi File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,4 +1 @@ | ||
yazi_macro::mod_flat!( | ||
backspace backward close complete delete escape forward insert kill move_ paste redo | ||
show type_ undo visual yank | ||
); | ||
yazi_macro::mod_flat!(backspace backward close complete delete escape forward insert kill move_ paste redo replace show type_ undo visual yank); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,31 @@ | ||
use yazi_macro::render; | ||
use yazi_shared::event::CmdCow; | ||
|
||
use crate::input::{Input, InputMode, op::InputOp}; | ||
|
||
impl Input { | ||
#[yazi_codegen::command] | ||
pub fn replace(&mut self, _: CmdCow) { | ||
let snap = self.snap_mut(); | ||
if snap.mode == InputMode::Normal { | ||
snap.op = InputOp::None; | ||
snap.mode = InputMode::Replace; | ||
render!(); | ||
} | ||
} | ||
|
||
// FIXME: need to create a new snap for each replace operation, otherwise we | ||
// can't undo/redo it with `u` and `Ctrl-r` | ||
pub fn replace_str(&mut self, s: &str) { | ||
let snap = self.snap_mut(); | ||
|
||
let start = snap.idx(snap.cursor).unwrap(); | ||
let end = snap.idx(snap.cursor + 1).unwrap(); // FIXME: panic if the input is empty while in replace mode | ||
|
||
snap.mode = InputMode::Normal; | ||
snap.value.replace_range(start..end, s); | ||
|
||
self.flush_value(); | ||
render!(); | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -3,6 +3,7 @@ pub enum InputMode { | |
Normal, | ||
#[default] | ||
Insert, | ||
Replace, | ||
} | ||
|
||
impl InputMode { | ||
|
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please fix these two
FIXME
s