plan_route_plugin: waypoints_ relative to target_frame #554
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
this modification of plan_route_plugin is mostly related to code simplification.
waypoints will contain poses relative to target_frame_, not stu::_wgs84_frame. This greatly reduces the need for tf_manager_.GetTransform() in many locations of the file, making it more readable.
Only inside the method PlanRoute() the conversion from target_frame_ to stu::_wgs84_frame is done.
if the latter transform fails, the mnm::PlanRoute is still send, with:
but maybe you do NOT want to do this...
Similarly, in Draw(), if this fails
a straight line is drawn instead. Personal taste I guess.
Since I don't have the PlanRoute server, I am not able to thoughtfully test it, though.
UPDATE: of course I did test 90% of these changes on my own fork, but I am unable to properly check anything related to the Route server
Davide