-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(styles): remove CSS icons #3947
Conversation
🦋 Changeset detectedLatest commit: d0f8e3b The changes in this PR will be included in the next version bump. This PR includes changesets to release 16 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Related Previews |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome! That's a huge change for a bright future.
@@ -61,9 +61,9 @@ | |||
|
|||
@if (map.has-key(icons.$svg-icon-map, #{$icon-name})) { | |||
$svg-url: map.get(icons.$svg-icon-map, #{$icon-name}); | |||
} @else if(map.has-key(icons.$svg-unofficial-icon-map, #{$icon-name})) { | |||
} @else if(map.has-key(icons.$next-icons, #{$icon-name})) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What are next-icons? Seems like a name that will age badly (what will the next next-icons be called? Next-next-icons?).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@gfellerph These are PPNL icons, I suppose they will come from the icons package in a near future but I can rename the map. What name would you choose?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@alizedebray sync with @oliverschuerch, I think he called the set UI icons.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rouven defined them as the „UI“ Icons, because they are exclusively made for the UI.
Since each of these icons lifes in a seperate file, contains up to 6 size variants, which are nested in <defs>
and <symbol>
elements and used through multiple <use>
tags combined with dark container query magic defined in the <post-icon>
component, I‘d not expect it’s even possible to implement them correctly in SCSS.
@alizedebray If you really want to see how far you can get, I can send you some of the output files already. Or I can open a draft PR (with out the <post-icon>
being ready), so you can export them by your self or start the icons preview page, where you’ll see how they work.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@oliverschuerch we are not talking about the same icon set. What I named $next-icons
are not the responsive icons but the 3 notification icons used for the PPNL form validation:
I'll rename the map to $notification-icons
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll approve as soon as unit and e2e tests are green ^.-
fd62178
to
89592ae
Compare
Quality Gate passedIssues Measures |
No description provided.