Revert "[Sema] Add specialization constraints for func and variable types, then diagnose w/fixes." #75489
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ypes, then diagnose w/fixes."
xedin
requested review from
hborla,
slavapestov,
ahoppen,
bnbarham,
CodaFi,
DougGregor,
hamishknight and
rintaro
as code owners
|
@swift-ci please smoke test |
|
@swift-ci please test source compatibility |
|
cc @gregomni |
|
@gregomni we need to reduce penny-bot failure, figure out what is wrong there and add it as a test-case. Looks like the failure in the dependency of penny-bot - DiscordBM, and the type is a macro - https://github.com/DiscordBM/DiscordBM/blob/main/Macros/UnstableEnumMacro/UnstableEnum.swift#L26 I have a suspicion that this was a situation that was ignored previously because the type wasn't resolved early enough, we might want to consider detecting situation like that and downgrading error to a warning in such cases. |
|
Or we need to make an exception to types that represent macros because they can have generic arguments at a use site it seems... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #74909
Causes a source compatibility regression in penny-bot project.