Use _NIOFileSystem for file system operations. #137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: Add support for _NIOFileSystem to move away from OSFileSystem as per issue swiftlang#76. Modifications: Add SDKFileSystem that uses _NIOFileSystem. Change default AsyncFileSystem to SDKFileSystem Result: Using Swift NIO for file system operations.
|
@swift-ci test |
MaxDesiatov
requested changes
Sep 30, 2024
| } | ||
| } | ||
|
|
||
| public func withOpenReadableFile<T: Sendable>( |
There was a problem hiding this comment.
I don't think we should reinvent the wheel here and reimplement with* methods from scratch. The main motivation for using _NIOFileSystem in the first place is that it already implements these methods and provides necessary abstractions, like FileSystemProtocol.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
Add support for _NIOFileSystem to move away from OSFileSystem as per issue #76.
Modifications:
Add SDKFileSystem that uses _NIOFileSystem. Change default AsyncFileSystem to SDKFileSystem
Result:
Using Swift NIO for file system operations.