Eliminate the warning that swift-syntax isn't being used. #8232
+11
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Assume dependent products from prebuilts are being used.
dschaefer2
requested review from
bnbarham,
MaxDesiatov,
jakepetroules,
francescomikulis,
xedin,
shawnhyam,
bripeticca,
plemarquand,
owenv and
bkhouri
as code owners
|
@swift-ci please test |
|
@swift-ci please test windows |
xedin
approved these changes
Jan 20, 2025
| @@ -352,9 +358,11 @@ private func checkAllDependenciesAreUsed( | |||
| let usedByPackage = productDependencies.contains { $0.name == product.name } | |||
| // We check if any of the products of this dependency is guarded by a trait. | |||
| let traitGuarded = traitGuardedProductDependencies.contains(product.name) | |||
| // Consider prebuilts as used | |||
| let prebuilt = prebuilts[dependency.identity]?.keys.contains(product.name) ?? false | |||
|
|
|||
| // If the product is either used directly or guarded by a trait we consider it as used | |||
There was a problem hiding this comment.
Nit: this comment has to be updated as well.
bkhouri
reviewed
Jan 21, 2025
That's what the change in PrebuiltsTest does. |
|
I'm going to lump this in with another bigger change coming to fix a serious bug. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Assume dependent products from prebuilts are being used.