New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refine format of Concurrency-Safe Notifications #1046

Open

li-bei wants to merge 1 commit into swiftlang:main from li-bei:format

li-bei commented Nov 13, 2024

Rename all makeMessage(:Notification) and makeNotification(:Self) to makeMessage(_:) and makeNotification(_:), which using the correct Swift method signature style.
Use NSWorkspace.applicationUserInfoKey instead of "applicationUserInfoKey".
Make all multi-line method definitions and calls using same style.

Contributor

cthielen commented Nov 13, 2024

@li-bei Thanks, these are good improvements.

I'll incorporate these changes in our next revision to avoid churn during the review period.


          Refine format of concurrency-safe-notifications.md

832f750

li-bei force-pushed the format branch from fd35084 to 832f750 Compare

November 13, 2024 23:21

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet