Fix upper bound in Calendar.RecurrenceRule.recurrences(of:in:) #1041
Conversation
This commit fixes the use of the `in:` bound in Calendar.RecurrenceRule.recurrences(of:in:) to properly exclude the upper bound as revealed by swiftlang#1040.
|
@swift-ci please test |
| let eventStart = Date(timeIntervalSince1970: 1285077600.0) // 2010-09-21T14:00:00-0000 | ||
| let results = Array(rule.recurrences(of: eventStart, in: start..<end)) | ||
|
|
||
| XCTAssertNotEqual(results.last!, end) |
There was a problem hiding this comment.
Instead of doing XCTAssertNotEqual, can you XCTAssertEqual what the last result should be?
There was a problem hiding this comment.
I can, but that changes the intent of the test, which is to ensure that end is not part of the recurrence. What the last value is doesn't actually matter for the purpose of this test.
There was a problem hiding this comment.
How about changing the assertion to XCTAssertLessThan?
There was a problem hiding this comment.
I understand what you want to test, but this line, XCTAssertNotEqual(results.last!, end), alone can mean anything if I hadn't looked at the code change. For example, this assert would pass if results is just an arbitrary value. Same goes with XCTAssertLessThan.
Also, instead of force unwrapping results.last!, it's useful to write it as XCTUnwrap (and have this test throw) instead of just force unwrapping it so we get a nice test report if it fails
There was a problem hiding this comment.
I was unaware of XCTUnwrap! That's neat! I'll make the changes later today!
This commit fixes the use of the
in:bound inCalendar.RecurrenceRule.recurrences(of:in:) to properly exclude the upper bound as revealed by #1040.