Restructure Examples folder #382
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabianfett
reviewed
Sep 30, 2024
Examples/v1/Benchmark/Package.swift
Outdated
| @@ -0,0 +1,53 @@ | |||
| // swift-tools-version:5.7 | |||
|
|
|||
| import PackageDescription | |||
There was a problem hiding this comment.
Why do we want to keep the v1 examples?
There was a problem hiding this comment.
For history and retro compatibility.
|
Done. @fabianfett do you have a hard feeling against keeping v1's ? |
Kinda. When users look at the repo, they don't necessarily know which version we are currently at. This might lead to confusion. Examples for v1 are still available in the v1 branch. |
|
@fabianfett There is no 1.0.0 branches, these are just tags. |
sebsto
force-pushed
the
sebsto/examples
branch
from
dadc879 to
426e658
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move all v1 examples to folder
Examples/v1Keep only v2 examples in
Examplesfolder