Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding missing spaces between words #1445

Closed
wants to merge 1 commit into from
Closed

Adding missing spaces between words #1445

wants to merge 1 commit into from

Conversation

Volendor
Copy link

@Volendor Volendor commented Jan 3, 2024

Small correction in .html: in some subheadings the words are stuck together.

Before:
Screenshot from 2024-01-03 19-30-19

After:
Screenshot from 2024-01-03 19-32-09

This is my very first pull request so I'm sorry if I did something wrong.

Copy link

github-actions bot commented Jan 3, 2024

🚫 The gh-pages branch is no longer editable 🚫

Thank you for your contribution. This lesson has migrated to use The Carpentries Workbench and the gh-pages branch is now automatically generated. This means in order to contribute, you will need to delete and re-fork this repository.

How to contribute

If you wish to contribute, you will need to use the following steps to delete, re-fork, and re-create your pull request (aka the burn it all down strategy):

  1. Save your edits on locally or in a scratch space.
  2. Delete your fork
  3. Create a new fork or use the "edit" button on the page you wish to edit.
  4. Apply your changes (NOTE The Workbench uses a different syntax. Here is a Transition Guide from Styles to Workbench for your reference).

Questions

If you have any questions or would like assistance, please contact @core-team-curriculum ([email protected]) or you can respond to this message.

@github-actions github-actions bot closed this Jan 3, 2024
@bkmgit
Copy link
Contributor

bkmgit commented Jan 3, 2024

Thanks. Markdown source https://github.com/swcarpentry/shell-novice/blob/main/episodes/02-filedir.md#exploring-more-ls-options seems ok - may need to figure out how to add extra space around rendered inline/code sections.

@tobyhodges
Copy link
Member

tobyhodges commented Jan 11, 2024

Hi @Volendor thanks for reporting this problem and submitting the PR to fix it.

A Carpentries lesson site is built from source files in the main branch of a GitHub repository. These source files are written in a markup language called Markdown 1 (or, in some cases, R Markdown), which are then converted by some automated processes into the HTML files displayed by the web browser when someone visits the lesson 2. Those automatically-generated HTML files are stored in the gh-pages branch of the lesson repository.

Your pull request was closed automatically because you submitted changes made directly to one of the HTML files in the gh-pages branch. Any changes made to the files in this branch will be overwritten the next time the HTML files are rebuilt, and this automatic closure process prevents such changes from taking place. Instead, for your changes to be properly incorporated in the lesson site for the longer term, you would edit the relevant source Markdown file in the main branch.

However, as @bkmgit mentioned above, there is no obvious error in that Markdown source file (and indeed the current version looks ok when I build the HTML from source using my local installation of the lesson infrastructure) so I do not think this problem can be fixed here. Rather, it is an issue with the lesson infrastructure itself, occurring in other lessons as well as reported here: carpentries/sandpaper#562

@Volendor Volendor deleted the pr/fix-typo branch January 17, 2024 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants