Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add example for failing type conversion #573

Closed
wants to merge 1 commit into from

Conversation

crlna16
Copy link

@crlna16 crlna16 commented Oct 8, 2021

Added an example where the type conversion from str to int fails for illutrative purposes. It is a common error and it is good for beginners to see it explicitly.

Instructions

Thanks for contributing! ❤️

If this contribution is for instructor training, please email the link to this contribution to
[email protected] so we can record your progress. You've completed your contribution
step for instructor checkout by submitting this contribution!

Keep in mind that lesson maintainers are volunteers and it may take them some time to
respond to your contribution. Although not all contributions can be incorporated into the lesson
materials, we appreciate your time and effort to improve the curriculum. If you have any questions
about the lesson maintenance process or would like to volunteer your time as a contribution
reviewer, please contact The Carpentries Team at [email protected].

You may delete these instructions from your comment.

- The Carpentries

Added an example where the type conversion from str to int fails for illutrative purposes. It is a common error and it is good for beginners to see it explicitly.
@alee
Copy link
Member

alee commented May 16, 2022

Thank you for the PR @crlna16 ! This example is appreciated, but we have a similar exercise already in http://swcarpentry.github.io/python-novice-gapminder/03-types-conversion/index.html#strings-to-numbers where we try to convert int('3.4') - it might be good to reiterate though, thoughts from others?

@vahtras
Copy link
Contributor

vahtras commented May 16, 2022 via email

@alee
Copy link
Member

alee commented Apr 19, 2023

closing this PR in preparation for a Carpentries-wide lesson infrastructure upgrade. Please feel free to resubmit after the Workbench upgrade / discuss in #600

@alee alee closed this Apr 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants