convert REPL to Svelte 5

[Rich-Harris]

WIP. I want to get rid of the run calls — they should just be $effect — but changing them breaks everything in incomprehensible ways

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
omnisite	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jun 25, 2024 4:21pm

[Rich-Harris]

hmm this appears to have broken svelte-split-pane. investigating

[Rich-Harris]

gah this is failing in strange ways. gonna redo it from scratch, more carefully

[dummdidumm]

Did it break when everything was using run, or just after moving them to $effect?
If the former that's a bit concerning. If the latter and if you figure out why it happened, would that be something to add to some sort of migration docs?

[Rich-Harris]

it was weird as hell — the moment I changed a run to an $effect, everything in my IDE went haywire. variables were erroneously marked as unused, red squigglies all over the place... it hinted at something deeply broken

[dummdidumm]

Mhhhm but that sounds more like a language-tools issue, no?
Is this reproducible within this PR? Like, "go to commit 3, everything fine, change run in file X to $effect, see everything break". And/or is this visible in the last commit of this branch? i.e. "restore the branch, open file X, see that everything's broken in the IDE"?

[Rich-Harris]

this should illustrate it — migrate CodeMirror.svelte, replace the first run with $effect, see the entire thing go haywire

weird-shit.mov

[dummdidumm]

Thanks - this is a language tools bug. There's an effect declaration somewhere in a function and it's wrongfully counted as a store declaration. That in combination with $effect then leads to some store declaration code being emitted which fucks everything up. Fix here: sveltejs/language-tools#2422