Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: directly copy file instead of streaming to stdin #771

Merged
merged 3 commits into from
Oct 24, 2023
Merged

fix: directly copy file instead of streaming to stdin #771

merged 3 commits into from
Oct 24, 2023

Conversation

pcnc
Copy link
Member

@pcnc pcnc commented Oct 24, 2023

  • Streaming to stdin has the habit of tarballing the targeted file, ending up with nested tarballs

@pcnc pcnc requested a review from a team as a code owner October 24, 2023 07:27
@pcnc pcnc merged commit 04e8008 into develop Oct 24, 2023
7 checks passed
@pcnc pcnc deleted the pcnc/fix-binary-collection-archive-nesting branch October 24, 2023 07:36
pcnc added a commit that referenced this pull request Oct 25, 2023
@pcnc
fix: directly copy file instead of streaming to stdin (#771)
7eab3d9 
* fix: directly copy file instead of streaming to stdin
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@delgado3d delgado3d delgado3d approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pcnc @delgado3d