-
-
Notifications
You must be signed in to change notification settings - Fork 148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP adding Envoy to the image #743
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally looks good, left minor comments
@darora @supaPatrick Can you share the rationale for introducing envoy? |
Hey Steve, in our testing it is using significantly less footprint in memory which was the desired outcome of replacing nginx/kong. |
@supaPatrick Oh, I see. Are the tests public? Or is there an internal Notion link? |
Here are some of the difference when running envoy other then kong
|
fe1bc67
to
8c5677c
Compare
…d version to run a test build
Looks good once we resolve #743 (comment) |
removed bash shell from service
this is what I think the initial commit for envoy into the image would look like. Envoy would be turned off and not in the same slice as other services but this commit would allow me to test easier moving forward.