Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: enhance pgmq.meta table validation checks #1379

Conversation

devin-ai-integration[bot]
Copy link

Enhance pgmq.meta table validation checks

This PR enhances the validation checks in the pgmq.meta backfill migration to ensure:

  • pgmq.meta is a regular table (not a view or materialized view)
  • Required columns exist: queue_name, is_partitioned, is_unlogged, created_at
  • No additional columns exist
  • Insert statement only executes if all conditions are met

Testing

  • Migration changes have been reviewed for SQL syntax and logic
  • No manual testing performed as this is a migration file change

Link to Devin run: https://app.devin.ai/sessions/ba98449afedc4fe8af288d2f5ca92121

- Verify pgmq.meta is a regular table
- Check for exact required columns
- Ensure no additional columns exist
- Only execute insert if all conditions are met

Co-Authored-By: [email protected] <[email protected]>
@devin-ai-integration devin-ai-integration bot requested a review from a team as a code owner December 16, 2024 16:57
Copy link
Author

🤖 Devin AI Engineer

I'll be helping with this pull request! Here's what you should know:

✅ I will automatically:

  • Address comments on this PR
  • Look at CI failures and help fix them

⚙️ Control Options:

  • Disable automatic comment and CI monitoring

Add "(aside)" to your comment to have me ignore it.

@olirice olirice closed this Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant