fix: permission denied for new roles and remove security definer functions #158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 17, 2024
steve-chavez
force-pushed
the
remove-secdef
branch
from
f26dadf to
d42a943
Compare
steve-chavez
commented
Oct 17, 2024
Comment on lines
+34
to
+80
| def test_net_on_another_role(sess): | ||
| """Check that a newly created role can use the net schema""" | ||
|
|
||
| sess.execute(text(""" | ||
| create role another; | ||
| """)) | ||
|
|
||
| # Create a request | ||
| (request_id,) = sess.execute(text( | ||
| """ | ||
| set local role to another; | ||
| select net.http_get( | ||
| 'http://localhost:8080/anything' | ||
| ); | ||
| """ | ||
| )).fetchone() | ||
|
|
||
| # Commit so background worker can start | ||
| sess.commit() | ||
|
|
||
| # Confirm that the request was retrievable | ||
| response = sess.execute( | ||
| text( | ||
| """ | ||
| set local role to another; | ||
| select * from net._http_collect_response(:request_id, async:=false); | ||
| """ | ||
| ), | ||
| {"request_id": request_id}, | ||
| ).fetchone() | ||
| assert response[0] == "SUCCESS" | ||
|
|
||
| ## can use the net.worker_restart function | ||
| response = sess.execute( | ||
| text( | ||
| """ | ||
| set local role to another; | ||
| select net.worker_restart(); | ||
| """ | ||
| ) | ||
| ).fetchone() | ||
| assert response[0] == True | ||
|
|
||
| sess.execute(text(""" | ||
| set local role postgres; | ||
| drop role another; | ||
| """)) |
There was a problem hiding this comment.
Note that these changes are tested
|
After this is merged, we can integrate the |
soedirgo
approved these changes
Oct 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #72. Also addresses https://github.com/orgs/supabase/discussions/21450.