Merge pull request #432 from supabase/fix/filter-trigger-funcs

do not expose trigger functions in GQL
supabase · Oct 9, 2023 · 6b9006b · 6b9006b
2 parents aeb1801 + 3b38221
commit 6b9006b
Show file tree

Hide file tree

Showing 3 changed files with 62 additions and 0 deletions.
diff --git a/src/sql_types.rs b/src/sql_types.rs
@@ -135,6 +135,8 @@ impl Function {
         if let Some(return_type) = types.get(&self.type_oid) {
             return_type.category != TypeCategory::Pseudo
                 && return_type.name != "record"
+                && return_type.name != "trigger"
+                && return_type.name != "event_trigger"
                 && !self.type_name.ends_with("[]")
         } else {
             false

diff --git a/test/expected/function_calls.out b/test/expected/function_calls.out
@@ -1954,6 +1954,12 @@ begin;
     )
         returns smallint language sql immutable
     as $$ select 0; $$;
+    create function returns_trigger()
+        returns trigger language plpgsql immutable
+    as $$ begin return null; end; $$;
+    create function returns_event_trigger()
+        returns event_trigger language plpgsql immutable
+    as $$ begin end; $$;
     select jsonb_pretty(
         graphql.resolve($$
             query IntrospectionQuery {
@@ -2155,4 +2161,38 @@ begin;
  }
 (1 row)
 
+    select jsonb_pretty(graphql.resolve($$
+        query {
+            returnsTrigger
+        }
+    $$));
+                              jsonb_pretty                               
+-------------------------------------------------------------------------
+ {                                                                      +
+     "data": null,                                                      +
+     "errors": [                                                        +
+         {                                                              +
+             "message": "Unknown field \"returnsTrigger\" on type Query"+
+         }                                                              +
+     ]                                                                  +
+ }
+(1 row)
+
+    select jsonb_pretty(graphql.resolve($$
+        query {
+            returnsEventTrigger
+        }
+    $$));
+                                 jsonb_pretty                                 
+------------------------------------------------------------------------------
+ {                                                                           +
+     "data": null,                                                           +
+     "errors": [                                                             +
+         {                                                                   +
+             "message": "Unknown field \"returnsEventTrigger\" on type Query"+
+         }                                                                   +
+     ]                                                                       +
+ }
+(1 row)
+
 rollback;
diff --git a/test/sql/function_calls.sql b/test/sql/function_calls.sql
@@ -701,6 +701,14 @@ begin;
         returns smallint language sql immutable
     as $$ select 0; $$;
 
+    create function returns_trigger()
+        returns trigger language plpgsql immutable
+    as $$ begin return null; end; $$;
+
+    create function returns_event_trigger()
+        returns event_trigger language plpgsql immutable
+    as $$ begin end; $$;
+
     select jsonb_pretty(
         graphql.resolve($$
             query IntrospectionQuery {
@@ -762,4 +770,16 @@ begin;
             concatText(a: "hello ")
         }
     $$));
+
+    select jsonb_pretty(graphql.resolve($$
+        query {
+            returnsTrigger
+        }
+    $$));
+
+    select jsonb_pretty(graphql.resolve($$
+        query {
+            returnsEventTrigger
+        }
+    $$));
 rollback;