Remove validator overwrite #63
Conversation
The is no need for a custom validator instance. It is bad practice for 3rd party packages to define rules this way.
Also, removed the custom resolver - the logic that is overwriting an application's validator instance.
Helper is responsible for creating validator instance with desired validation rules...
|
Note: I'm not sure what/why code-coverage is failing. @sunspikes, if you approve of the changes, can you please take over the PR and fix eventual coverage related issues? |
|
@sunspikes are you still around? |
|
@sunspikes This change is in line with how new rules should be added to laravel projects, and as such would be a huge improvement to this package. Could you please consider merging this PR, or if this package is abandoned, marking it as such so someone else can take over? |
|
To anyone that might come across this PR. Due to lack of activity from the author, I was forced to create an alternative. I hold no ill intention towards the author and hope that he may become active again in the future. |
|
Voting for this PR to be merged 👍🏼 cc @sunspikes |
|
Should this package be archived or should this PR be merged? 👀 |
|
@bradietilley I can see that the author has recently been active on this package - he added support for Laravel v11 (at least in the composer file). But I cannot say why this PR has not received any attention. |
|
Thank you for this, currently Im mostly disconnected, I will check this and merge asap, sorry for the delay! |
|
Thank you @aedart and sorry for the late merge |
This PR extracts validation logic out of the custom validation and into its own class, which is then installed as a validation extension, via the service provider.
The custom validator has now been marked as deprecated, because it is really not needed. The validation rule is sufficient.
Lastly, the unit tests have also been adapted to no longer rely on the custom validator instance.
Related
Additional Context
Recently I found myself in a bad situation - I needed to overwrite my application's Validator instance to manually fix an issue. To my great surprise, I found that this package already had overwritten the validator and caused me some frustration (I was not aware of this behaviour).
In any case, I thought that I would take a look at how your package could be improved, to avoid the above mentioned situation.