Skip to content

Commit

Permalink
Updated to the final .NET Core 3.0 release; enabled UseLayoutRounding…
Browse files Browse the repository at this point in the history
… for the Views; fixed some C# nullables; updated/removed stuff related to publishing
  • Loading branch information
sungaila committed Sep 29, 2019
1 parent 8d0843a commit 2604a52
Show file tree
Hide file tree
Showing 10 changed files with 16 additions and 32 deletions.
2 changes: 1 addition & 1 deletion Core/ViewModel.cs
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ public abstract class ViewModel
/// Implementation of <see cref="INotifyPropertyChanged.PropertyChanged"/>.
/// Is used to support bindings between views and view model properties.
/// </summary>
public event PropertyChangedEventHandler PropertyChanged;
public event PropertyChangedEventHandler? PropertyChanged;

/// <summary>
/// Raises the <see cref="PropertyChanged"/> event for the given property name.
Expand Down
2 changes: 1 addition & 1 deletion Core/ViewModelCommand.cs
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ public abstract class ViewModelCommand<TViewModel>
: IViewModelCommand
where TViewModel : ViewModel
{
public event EventHandler CanExecuteChanged;
public event EventHandler? CanExecuteChanged;

bool ICommand.CanExecute(object parameter)
{
Expand Down
4 changes: 0 additions & 4 deletions Properties/PublishProfiles/Portable.pubxml
Original file line number Diff line number Diff line change
Expand Up @@ -10,9 +10,5 @@ https://go.microsoft.com/fwlink/?LinkID=208121.
<TargetFramework>netcoreapp3.0</TargetFramework>
<PublishDir>bin\Release\netcoreapp3.0\publish\portable</PublishDir>
<SelfContained>false</SelfContained>
<_IsPortable>true</_IsPortable>
<PublishSingleFile>false</PublishSingleFile>
<PublishTrimmed>false</PublishTrimmed>
<PublishReadyToRun>false</PublishReadyToRun>
</PropertyGroup>
</Project>
19 changes: 0 additions & 19 deletions Properties/PublishProfiles/Standalone (win-arm).pubxml

This file was deleted.

3 changes: 1 addition & 2 deletions Properties/PublishProfiles/Standalone (win-x64).pubxml
Original file line number Diff line number Diff line change
Expand Up @@ -9,9 +9,8 @@ https://go.microsoft.com/fwlink/?LinkID=208121.
<Platform>x64</Platform>
<TargetFramework>netcoreapp3.0</TargetFramework>
<PublishDir>bin\Release\netcoreapp3.0\publish\win-x64</PublishDir>
<RuntimeIdentifier>win-x64</RuntimeIdentifier>
<SelfContained>true</SelfContained>
<_IsPortable>false</_IsPortable>
<RuntimeIdentifier>win-x64</RuntimeIdentifier>
<PublishSingleFile>true</PublishSingleFile>
<PublishTrimmed>true</PublishTrimmed>
<PublishReadyToRun>true</PublishReadyToRun>
Expand Down
3 changes: 1 addition & 2 deletions Properties/PublishProfiles/Standalone (win-x86).pubxml
Original file line number Diff line number Diff line change
Expand Up @@ -9,9 +9,8 @@ https://go.microsoft.com/fwlink/?LinkID=208121.
<Platform>x86</Platform>
<TargetFramework>netcoreapp3.0</TargetFramework>
<PublishDir>bin\Release\netcoreapp3.0\publish\win-x86</PublishDir>
<RuntimeIdentifier>win-x86</RuntimeIdentifier>
<SelfContained>true</SelfContained>
<_IsPortable>false</_IsPortable>
<RuntimeIdentifier>win-x86</RuntimeIdentifier>
<PublishSingleFile>true</PublishSingleFile>
<PublishTrimmed>true</PublishTrimmed>
<PublishReadyToRun>true</PublishReadyToRun>
Expand Down
8 changes: 7 additions & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,14 @@ A GUI for mapping directories to virtual drives (see *SUBST* command). It is bui

<img src="https://raw.githubusercontent.com/sungaila/SUBSTitute/master/Content/0.9.3_Screenshot.png" width="390" alt="Screenshot from version 0.9.3">

While its primary goal is to offer a convenient GUI for the *SUBST* command, I use it as a playground to test C# 8.0, .NET Core and WPF stuff. That's why the code is bloated and/or overengineered.
While its primary goal is to offer a convenient GUI for the *SUBST* command, I use it as a playground to test C# 8.0, .NET Core and WPF stuff.

At this point I am satisfied with SUBSTitute: There are no major features/changes planned. I still keep an eye on .NET Core updates, though. And I might expand on the easter egg (about dialog) just for fun.
## Version history
### 1.0.0 (2019-09-29)
* Target framework updated to [.NET Core 3.0.0](https://github.com/dotnet/core/blob/master/release-notes/3.0/3.0.0/3.0.0.md) (stable version)
* Changed UI render settings so it looks less blurry on certain displays and DPI settings
* Code and project file cleanup (now that the framework is stable and not a preview anymore)
### 0.9.5 (2019-08-22)
* Target framework updated to [.NET Core 3.0.0 Preview 8](https://github.com/dotnet/core/blob/master/release-notes/3.0/preview/3.0.0-preview8.md)
* Fixed issues with C# 8 nullables (due to updating to preview 7 last time)
Expand Down
5 changes: 3 additions & 2 deletions SUBSTitute.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
<RootNamespace>Sungaila.SUBSTitute</RootNamespace>
<StartupObject>Sungaila.SUBSTitute.App</StartupObject>
<ApplicationIcon>SUBSTitute.ico</ApplicationIcon>
<Version>0.9.5</Version>
<Version>1.0.0</Version>
<Authors>David Sungaila</Authors>
<Copyright>Coypright © 2019 SUBSTitute</Copyright>
<Company />
Expand Down Expand Up @@ -64,6 +64,7 @@
<ItemGroup>
<Content Include="licence.txt">
<CopyToOutputDirectory>PreserveNewest</CopyToOutputDirectory>
<ExcludeFromSingleFile>true</ExcludeFromSingleFile>
</Content>
<Resource Include="Misc\Anger.png">
<CopyToOutputDirectory>Never</CopyToOutputDirectory>
Expand Down Expand Up @@ -114,7 +115,7 @@
<ItemGroup>
<PackageReference Include="Microsoft.WindowsAPICodePack-Core" Version="1.1.0.2" />
<PackageReference Include="Microsoft.WindowsAPICodePack-Shell" Version="1.1.0" />
<PackageReference Include="System.Drawing.Common" Version="4.6.0-preview8.19405.3" />
<PackageReference Include="System.Drawing.Common" Version="4.6.0" />
</ItemGroup>

</Project>
1 change: 1 addition & 0 deletions Views/AboutDialog.xaml
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@
Background="{DynamicResource {x:Static SystemColors.ControlBrushKey}}"
ResizeMode="NoResize"
SnapsToDevicePixels="True"
UseLayoutRounding="True"
WindowStartupLocation="CenterOwner"
mc:Ignorable="d">

Expand Down
1 change: 1 addition & 0 deletions Views/MainWindow.xaml
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@
DpiChanged="Window_DpiChanged"
SizeToContent="Height"
SnapsToDevicePixels="True"
UseLayoutRounding="True"
mc:Ignorable="d">

<Grid Margin="7">
Expand Down

0 comments on commit 2604a52

Please sign in to comment.